Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-115986 Improve pprint documentation accuracy #117403

Merged
merged 2 commits into from
Apr 22, 2024
Merged

gh-115986 Improve pprint documentation accuracy #117403

merged 2 commits into from
Apr 22, 2024

Conversation

Privat33r-dev
Copy link
Contributor

@Privat33r-dev Privat33r-dev commented Mar 31, 2024 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 31, 2024
Closed
@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Mar 31, 2024
@Privat33r-dev
Copy link
Contributor Author

Privat33r-dev commented Apr 14, 2024 •
edited
Loading

@erlend-aasland any interest reviewing? :) The issue is almost closed, just the last 2 PRs.

@erlend-aasland erlend-aasland changed the title gh-115986 Docs: Improve pprint documentation accuracy gh-115986 Improve pprint documentation accuracy Apr 14, 2024
@erlend-aasland erlend-aasland added the needs backport to 3.12 bug and security fixes label Apr 14, 2024
erlend-aasland
erlend-aasland approved these changes Apr 14, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. cc. @AlexWaygood who participated on the issue.

@Privat33r-dev @JelleZijlstra
Increase explicity
5490a74 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@erlend-aasland erlend-aasland merged commit ceb6038 into python:main Apr 22, 2024
25 checks passed
@miss-islington-app
Copy link

Thanks @Privat33r-dev for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2024
@Privat33r-dev @JelleZijlstra @miss-islington
pythongh-115986 Improve pprint documentation accuracy (pythonGH-117403)
84a4186 
(cherry picked from commit ceb6038)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Apr 22, 2024

GH-118146 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Apr 22, 2024
erlend-aasland pushed a commit that referenced this pull request Apr 22, 2024
@miss-islington @Privat33r-dev @JelleZijlstra
[3.12] gh-115986 Improve pprint documentation accuracy (GH-117403) (#…
b1e5f27 
…118146)

(cherry picked from commit ceb6038)

Co-authored-by: Kerim Kabirov <the.privat33r+gh@pm.me>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Privat33r-dev @JelleZijlstra @erlend-aasland